Remove LinuxImageDemand and WindowsImageDemand variables from pipeline configuration#45808
Merged
weshaggard merged 3 commits intoJun 24, 2025
Merged
Conversation
…ml and replace usages Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove LinuxImageDemand and WindowsImageDemand from image.yml and replace usages with variable values
Remove LinuxImageDemand and WindowsImageDemand variables from pipeline configuration
Jun 24, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the intermediary LinuxImageDemand variable from the pipeline configuration and replaces its usage with a hardcoded string value to align with changes in the Azure/azure-sdk-for-net repository.
- Removed the LinuxImageDemand variable definition from eng/pipelines/templates/variables/image.yml.
- Updated eng/pipelines/docindex.yml to use the hardcoded value "ImageOverride -equals ubuntu-24.04" in place of the variable.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/templates/variables/image.yml | Removed the LinuxImageDemand variable to eliminate unnecessary indirection. |
| eng/pipelines/docindex.yml | Replaced variable reference with a hardcoded string value. |
Comments suppressed due to low confidence (2)
eng/pipelines/docindex.yml:31
- [nitpick] Consider adding an inline comment explaining why the literal value is used instead of a variable to improve future clarity and maintainability.
demands: ImageOverride -equals ubuntu-24.04
weshaggard
approved these changes
Jun 24, 2025
weshaggard
reviewed
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the
LinuxImageDemandandWindowsImageDemandvariables from allimage.ymlfiles and replaces their usage with hardcoded string values. This aligns with the changes made in Azure/azure-sdk-for-net#50802.Changes Made
LinuxImageDemandvariable from/eng/pipelines/templates/variables/image.yml/eng/pipelines/docindex.ymlto use the hardcoded valueImageOverride -equals ubuntu-24.04instead of$(LinuxImageDemand)WindowsImageDemandwas not present in the codebaseBefore
After
Validation
The replacement value
ImageOverride -equals ubuntu-24.04was determined by resolving the original variable definition:LinuxImageDemand = "ImageOverride -equals $(LINUXVMIMAGE)"whereLINUXVMIMAGE = "ubuntu-24.04".💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.